On Thu, 27 Feb 2025 17:52:25 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> This PR adds the release notes for the JavaFX 24 release. This will first go 
>> into master, and then be backported to the jfx24 branch so it will be 
>> available in that branch when JavaFX 24 is published (and from there also 
>> synced into the jfx24u repo).
>> 
>> The following filter was used to produce the list of issues fixed in JavaFX 
>> 24:
>> 
>> https://bugs.openjdk.org/issues/?filter=46704
>> 
>> Additionally, we had seven issues with a release-note=yes label, which are 
>> included in the list of important changes, etc (one of them is still pending 
>> the text for the release note).
>
> doc-files/release-notes-24.md line 51:
> 
>> 49: 
>> 50: NOTE: The above will fail if you run your application with JDK 23 or 
>> earlier. JDK 24 is recommended when running JavaFX 24, but if you choose to 
>> run JavaFX 24 with an earlier JDK, use the `--module-path` option instead.
>> 51: 
> 
> do you think we could also show an example here?

No, I think there is enough information already for someone who chooses to run 
JavaFX on an older JDK. I don't want to distract with too much information that 
is irrelevant in the typical case.

> doc-files/release-notes-24.md line 54:
> 
>> 52: #### Applications using `jlink` to create a custom Java runtime image:
>> 53: 
>> 54: When creating your custom Java runtime image, put the JavaFX jmods on 
>> the module path ahead of the JDK jmoods. For example:
> 
> jmoods

Ooooops. :)

I'll fix.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1712#discussion_r1974194985
PR Review Comment: https://git.openjdk.org/jfx/pull/1712#discussion_r1974195666

Reply via email to