On Fri, 28 Feb 2025 15:56:19 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> This PR adds the release notes for the JavaFX 24 release. This will first go >> into master, and then be backported to the jfx24 branch so it will be >> available in that branch when JavaFX 24 is published (and from there also >> synced into the jfx24u repo). >> >> The following filter was used to produce the list of issues fixed in JavaFX >> 24: >> >> https://bugs.openjdk.org/issues/?filter=46704 >> >> Additionally, we had seven issues with a release-note=yes label, which are >> included in the list of important changes, etc (one of them is still pending >> the text for the release note). > > Kevin Rushforth has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8340852-info.md --> JDK-8340852-ScrollPane.md Marked as reviewed by jhendrikx (Reviewer). doc-files/release-notes-24.md line 66: > 64: See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) for more > information. > 65: > 66: ### Pluggable Image Loading via javax.imageio Suggestion: ### Pluggable Image Loading via `javax.imageio` doc-files/release-notes-24.md line 70: > 68: JavaFX 24 supports the Java Image I/O API, allowing applications to use > third-party image loaders in addition to the built-in image loaders. This > includes the ability to use variable-density image loaders for formats like > SVG. When an image is loaded using a variable-density image loader, JavaFX > rasterizes the image with the screen's DPI scaling. > 69: > 70: Applications that want to use this feature can use existing open-source > Image I/O extension libraries, or register a custom Image I/O service > provider instance with the IIORegistry class. Refer to the Java Image I/O > documentation for more information. Suggestion: Applications that want to use this feature can use existing open-source Image I/O extension libraries, or register a custom Image I/O service provider instance with the `IIORegistry` class. Refer to the Java Image I/O documentation for more information. doc-files/release-notes-24.md line 74: > 72: See [JDK-8306707](https://bugs.openjdk.org/browse/JDK-8306707) for more > information. > 73: > 74: ### ScrollPane Consumes Navigation Keys Only When It Has Direct Focus Suggestion: ### `ScrollPane` Consumes Navigation Keys Only When It Has Direct Focus doc-files/release-notes-24.md line 90: > 88: Likewise, as of JavaFX 24, it is no longer possible to run JavaFX > applications with a security manager enabled. This is true even if you run > your application on an older JDK that still supports the security manager. > 89: > 90: The following exception will be thrown when the JavaFX runtime is > initialized if the Security Manager is enabled: I think this would flow better as: Suggestion: The following exception will be thrown when the JavaFX runtime is initialized with the Security Manager enabled: doc-files/release-notes-24.md line 100: > 98: ## Known Issues > 99: > 100: ### JavaFX Warning Printed for Use of Terminally Deprecated Methods in > sun.misc.Unsafe Suggestion: ### JavaFX Warning Printed for Use of Terminally Deprecated Methods in `sun.misc.Unsafe` ------------- PR Review: https://git.openjdk.org/jfx/pull/1712#pullrequestreview-2652377958 PR Review Comment: https://git.openjdk.org/jfx/pull/1712#discussion_r1976381908 PR Review Comment: https://git.openjdk.org/jfx/pull/1712#discussion_r1976382334 PR Review Comment: https://git.openjdk.org/jfx/pull/1712#discussion_r1976382191 PR Review Comment: https://git.openjdk.org/jfx/pull/1712#discussion_r1976381703 PR Review Comment: https://git.openjdk.org/jfx/pull/1712#discussion_r1976382418