On Thu, 5 Dec 2024 09:22:34 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSkinBase.java >> line 432: >> >>> 430: } >>> 431: >>> 432: double getFixedCellSize() { >> >> should this method be `abstract`? > > We can do that, but then it should be `protected` as well, so custom code > that extends from `TableRowSkinBase` can override this. If it is package > private, custom code can not. > > This will require a CSR hovever, so I think it is better as a follow up > (there might be some more occurrences that should be `protected abstract` in > this class) good point. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1645#discussion_r1871602450