On Fri, 31 Jan 2025 23:03:54 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> The very first (visible) node should be created in the FX application thread >> (something I missed earlier). All other instances are created in the >> background thread - notice the second call to `generator.get()` inside the >> background thread lambda. > >> Related to this, I think a separate set of tests where we construct >> instances of the node in a loop would be useful, in addition to the set of >> tests that mutates the node in a loop. > > this is a good idea! thank you. > The very first (visible) node should be created in the FX application thread > (something I missed earlier). All other instances are created in the > background thread - notice the second call to `generator.get()` inside the > background thread lambda. Ah, I see that now (I had missed seeing the second call). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1690#discussion_r1939699573
