On Wed, 8 Jan 2025 22:23:38 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> I only pointed this out as I didn't see removal of the old `.root` code, in 
>> which case it should either still be documented or mentioned that it will be 
>> removed in the future.  I can go with either solution.
>
> Even if it is deprecated for removal, it won't be an instantaneous event.  We 
> still need to document that, and even go further and add a warning that it 
> will be removed, to make sure all the developers have updated their 
> stylesheets.
> 
> It probably makes more sense just to keep it, for backward compatibility.
> 
> I don't think we want some banking application to go haywire when the 
> selector gets removed.  There is a value in backward compatibility.

I am not in favor of deprecating this for removal. I can see a possible 
argument for simple deprecation (although since it isn't a Java level API, it 
isn't clear what that would mean or what the benefit would be), but that could 
be done later if there was a desire to pursue it.

I do think we should continue to documenting it.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1652#discussion_r1907936768

Reply via email to