On Wed, 8 Jan 2025 12:05:56 GMT, John Hendrikx <[email protected]> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into feature/root-pseudo-class
>> - whitespace error
>> - add child-indexed pseudo-classes
>> - add pseudo-class table to Parent
>> - update cssref
>> - Set :root pseudo-class on sub-scene root node
>> - Set :root pseudo-class on root node
>
> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line
> 1530:
>
>> 1528: <p>In the following example, all background color of all buttons
>> uses the
>> 1529: looked up color "abc".</p>
>> 1530: <p class="example">:root { abc: #f00 }<br>
>
> I see many places where `.root` is removed in favor of `:root`, but both are
> supported still? At least, the code in `Scene` leads me to believe that it
> will also apply the `.root` style class still. Should this legacy style
> class be mentioned in the CSS documentation still?
It will still be supported for backwards compatibility, but I see no reason to
mention that now that we have the standard-conformant `:root` pseudo-class.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1652#discussion_r1907546471
