On Wed, 20 Nov 2024 23:58:50 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 66 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - hide skin input map >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - whitespace >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - save as >> - removed function handler >> - removed add handler last >> - use focus traversal api >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - ... and 56 more: https://git.openjdk.org/jfx/compare/3a8a5598...e45be7b7 > > modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/KeyBinding.java > line 198: > >> 196: * @return the KeyBinding, or null >> 197: */ >> 198: public static KeyBinding shiftOption(KeyCode code) { > > Is there a `shiftAlt` that would make sense on other platforms? If so, maybe > that could supersede this? I haven't needed shift-alt, but I suppose it can be added for other platforms. shift-option, on the other hand is used on mac (in the TextInputControl hierarchy, for example). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1853054950
