On Thu, 21 Nov 2024 19:20:47 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 66 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - hide skin input map >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - whitespace >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - save as >> - removed function handler >> - removed add handler last >> - use focus traversal api >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - ... and 56 more: https://git.openjdk.org/jfx/compare/3a8a5598...e45be7b7 > > modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/EventCriteria.java > line 31: > >> 29: >> 30: /** >> 31: * This interface enables wider control in specifying conditional >> matching logic when adding skin/behavior handlers. > > Can this interface be hidden as well? It may not need to be in the public API > now that SkinInputMap and BehaviorBase aren't. > > If it still needs to be part of the public API, it will need a better > description. One that answers the questions: What is the purpose of this > interface? Who implements it? Who uses it? yes, it can be hidden for now. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1852973308
