On Thu, 21 Nov 2024 00:00:27 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 66 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - hide skin input map >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - whitespace >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - save as >> - removed function handler >> - removed add handler last >> - use focus traversal api >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - ... and 56 more: https://git.openjdk.org/jfx/compare/3a8a5598...e45be7b7 > > modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/KeyBinding.java > line 269: > >> 267: /** >> 268: * Determines whether {@code alt} key is down in this key binding. >> 269: * @return true if {@code alt} key is down in this key binding > > Does this return true if the `option` key is down on macOS? I thought I got rid of it, it is unnecessary. is[Modifier] methods will be removed. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1852859271
