On Wed, 6 Nov 2024 11:59:10 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 52 commits: >> >> - readme >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - review comments >> - input map >> - validate model >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - javadoc >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - review comments >> - measurement node >> - ... and 42 more: https://git.openjdk.org/jfx/compare/bd4bc057...a51ae151 > > modules/jfx.incubator.input/src/main/java/com/sun/jfx/incubator/scene/control/input/PHList.java > line 46: > >> 44: * [ USER_HIGH, handler1, handler2, SKIN_KB, SKIN_LOW, handler3 ] >> 45: */ >> 46: private final ArrayList<Object> items = new ArrayList(4); > > Is there any specific reason as to why initial size is 4 ? Could use a final > constant instead. no-need, it's the best guesstimate > modules/jfx.incubator.input/src/main/java/com/sun/jfx/incubator/scene/control/input/PHList.java > line 88: > >> 86: /** >> 87: * Removes all the instances of the specified handler. Returns true >> if the list becomes empty as a result. >> 88: * Returns true if the list becomes empty as a result of the removal. > > `Returns true if the list becomes empty as a result` :-> This comment is > repeated on line 87 and 88. It can be removed from line 87. that should be fine, even if a bit redundant ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1833482018 PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1833482812
