On Wed, 6 Nov 2024 11:52:35 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 52 commits: >> >> - readme >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - review comments >> - input map >> - validate model >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - javadoc >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - review comments >> - measurement node >> - ... and 42 more: https://git.openjdk.org/jfx/compare/bd4bc057...a51ae151 > > modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/KeyBinding.java > line 708: > >> 706: } else if (linux) { >> 707: replace(KCondition.SHORTCUT, KCondition.CTRL); >> 708: } > > the two else blocks can be combined into one. > > else if (win || linux) { > replace(KCondition.SHORTCUT, KCondition.CTRL); > } unless there are more changes due to e.g. using mac hardware with linux... ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1833365199
