On Fri, 13 Sep 2024 19:35:26 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> Further additions to the MonkeyTester application:
>> 
>> - tree/table view column property sheets ✔
>> - new pages: button, checkbox, hyperlink, menu bar, radio button, toggle 
>> button, canvas, split menu button, dnd ✔
>> - properties... context menu ✔
>> - context menu: table columns, toolbar items ✔
>> - control.context menu option
>> - property monitor tool ✔
>> - accessibility logging ✔
>> 
>> - editable combobox for double values with pre-set list (e.g. Region: 
>> min/max width etc.)
>> - Page -> Snapped Split Panes menu option for the control container
>> 
>> This PR simply syncs up with the dev repository
>> https://github.com/andy-goryachev-oracle/MonkeyTest
>
> Andy Goryachev has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains four additional 
> commits since the last revision:
> 
>  - review comments
>  - Merge remote-tracking branch 'origin/master' into 8328828.monkey
>  - whitespace
>  - 8328828: Monkey Tester Application Part 4

Few quick copyright year changes required. Shall approve once changed.

tests/manual/monkey/src/com/oracle/tools/fx/monkey/settings/FxSettingsSchema.java
 line 2:

> 1: /*
> 2:  * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.

Looks unintended, can be reverted.

tests/manual/monkey/src/com/oracle/tools/fx/monkey/settings/SStream.java line 2:

> 1: /*
> 2:  * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.

Looks unintended, can be reverted.

tests/manual/monkey/src/com/oracle/tools/fx/monkey/tools/Native2AsciiPane.java 
line 2:

> 1: /*
> 2:  * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.

Looks unintended, can be reverted.

-------------

Changes requested by arapte (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1560#pullrequestreview-2305734523
PR Review Comment: https://git.openjdk.org/jfx/pull/1560#discussion_r1760522617
PR Review Comment: https://git.openjdk.org/jfx/pull/1560#discussion_r1760522836
PR Review Comment: https://git.openjdk.org/jfx/pull/1560#discussion_r1760525928

Reply via email to