On Mon, 9 Sep 2024 19:36:29 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> Further additions to the MonkeyTester application: > > - tree/table view column property sheets ✔ > - new pages: button, checkbox, hyperlink, menu bar, radio button, toggle > button, canvas, split menu button, dnd ✔ > - properties... context menu ✔ > - context menu: table columns, toolbar items ✔ > - control.context menu option > - property monitor tool ✔ > - accessibility logging ✔ > > - editable combobox for double values with pre-set list (e.g. Region: min/max > width etc.) > - Page -> Snapped Split Panes menu option for the control container > > This PR simply syncs up with the dev repository > https://github.com/andy-goryachev-oracle/MonkeyTest Providing a few comments observed when running MonkeyTester app. 1. Z transformations Scale Z / Translate Z can be avoided for 2D controls / shapes 2. TreeTableView height is fixed. It always shows 1 row. Changes in TreeTableView->Root does not have any effect. Height of TTV could vary with the number of rows. 3. Button: Button does not receive ENTER key press event when set as default button. 3.1 Check default button. 3.2 Move focus on button by clicking on it 3.3 Press ENTER key => button does not show pressed effect. Press space button, button shows pressed effect. 4. ChoiceBox/ColorPicker/MenuBar background cannot be set back to the default. Changing back the background to <null> has no effect 5. No pages were getting rendered after following NPE was observed with RadioButton sample: Attaching the user preferences file with which issue can be reproduced [ui-settings.properties.zip](https://github.com/user-attachments/files/16978042/ui-settings.properties.zip) Exception in thread "JavaFX Application Thread" java.lang.NullPointerException: Cannot invoke "javafx.geometry.Pos.getHpos()" because the return value of "javafx.scene.control.RadioButton.getAlignment()" is null at javafx.controls@24-internal/javafx.scene.control.skin.RadioButtonSkin.layoutChildren(RadioButtonSkin.java:136) at javafx.controls@24-internal/javafx.scene.control.Control.layoutChildren(Control.java:612) at javafx.graphics@24-internal/javafx.scene.Parent.layout(Parent.java:1208) at javafx.graphics@24-internal/javafx.scene.Parent.layout(Parent.java:1215) at javafx.graphics@24-internal/javafx.scene.Parent.layout(Parent.java:1215) at javafx.graphics@24-internal/javafx.scene.Parent.layout(Parent.java:1215) at javafx.graphics@24-internal/javafx.scene.Parent.layout(Parent.java:1215) at javafx.graphics@24-internal/javafx.scene.Parent.layout(Parent.java:1215) at javafx.graphics@24-internal/javafx.scene.Parent.layout(Parent.java:1215) at javafx.graphics@24-internal/javafx.scene.Parent.layout(Parent.java:1215) at javafx.graphics@24-internal/javafx.scene.Parent.layout(Parent.java:1215) at javafx.graphics@24-internal/javafx.scene.Parent.layout(Parent.java:1215) at javafx.graphics@24-internal/javafx.scene.Parent.layout(Parent.java:1215) at javafx.graphics@24-internal/javafx.scene.Parent.layout(Parent.java:1215) at javafx.graphics@24-internal/javafx.scene.Scene.doLayoutPass(Scene.java:596) at javafx.graphics@24-internal/javafx.scene.Scene$ScenePulseListener.pulse(Scene.java:2603) at javafx.graphics@24-internal/com.sun.javafx.tk.Toolkit.lambda$runPulse$2(Toolkit.java:401) at java.base/java.security.AccessController.doPrivileged(AccessController.java:400) at javafx.graphics@24-internal/com.sun.javafx.tk.Toolkit.runPulse(Toolkit.java:400) at javafx.graphics@24-internal/com.sun.javafx.tk.Toolkit.firePulse(Toolkit.java:430) at javafx.graphics@24-internal/com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:598) at javafx.graphics@24-internal/com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:578) at javafx.graphics@24-internal/com.sun.javafx.tk.quantum.QuantumToolkit.pulseFromQueue(QuantumToolkit.java:571) at javafx.graphics@24-internal/com.sun.javafx.tk.quantum.QuantumToolkit.lambda$runToolkit$11(QuantumToolkit.java:352) at javafx.graphics@24-internal/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95) tests/manual/monkey/src/com/oracle/tools/fx/monkey/util/WritingSystemsDemo.java line 2: > 1: /* > 2: * Copyright (c) 2023, 2024, Oracle and/or its affiliates. All rights > reserved. Looks like unintended change. could be reverted. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1560#issuecomment-2345999475 PR Review Comment: https://git.openjdk.org/jfx/pull/1560#discussion_r1756649126
