On Thu, 15 Aug 2024 17:53:00 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> I do that too, typically. But here I just copied some code from a sibling >> test. >> >> If we are converting, then we also should convert MenuButtonTest as well, >> and now we are widening the scope. There is no gain in going with junit5 >> with this test specifically, so I don't really want to do it right now, I >> would rather do it as a part of a bulk change. >> >> Do you want me to convert this test? > > created https://bugs.openjdk.org/browse/JDK-8338468 It's okay, I'd just like to see it get done _eventually_. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1535#discussion_r1718798147