On Thu, 15 Aug 2024 17:41:44 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> I think that would be out of scope for this PR. >> >> We are considering updating tests to junit5 in bulk at some point, but I >> suspect it's a fairly low priority, unless we need to address something like >> https://bugs.openjdk.org/browse/JDK-8328629 > > Well, you _do_ modify this file significantly, so it's not entirely out of > scope. I've been converting files over to JUnit5 in the past as part of > significant modifications, I think it's a valid path to get us to eventually > move completely to JUnit5 (because as you say, bulk conversion isn't probably > happening any time soon). I do that too, typically. But here I just copied some code from a sibling test. If we are converting, then we also should convert MenuButtonTest as well, and now we are widening the scope. There is no gain in going with junit5 with this test specifically, so I don't really want to do it right now, I would rather do it as a part of a bulk change. Do you want me to convert this test? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1535#discussion_r1718781360
