On Thu, 15 Aug 2024 17:07:40 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/SplitMenuButtonTest.java >> line 34: >> >>> 32: import org.junit.Test; >>> 33: >>> 34: import static org.junit.Assert.*; >> >> Since you're modifying this file significantly, you could also use the >> JUnit5 imports. > > I think that would be out of scope for this PR. > > We are considering updating tests to junit5 in bulk at some point, but I > suspect it's a fairly low priority, unless we need to address something like > https://bugs.openjdk.org/browse/JDK-8328629 Well, you _do_ modify this file significantly, so it's not entirely out of scope. I've been converting files over to JUnit5 in the past as part of significant modifications, I think it's a valid path to get us to eventually move completely to JUnit5 (because as you say, bulk conversion isn't probably happening any time soon). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1535#discussion_r1718773749
