On Fri, 2 Aug 2024 21:30:49 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - fix since tag
>> - adjust table styling
>
> modules/javafx.graphics/src/main/java/javafx/css/ComponentTransitionable.java
> line 35:
>
>> 33: * Identifies a class that supports component-wise CSS transitions.
>> 34: * <p>
>> 35: * Component-wise transitions offer more flexibility than {@link
>> Interpolatable} transitions.
>
> Why is the name not `ComponentInterpolatable`?
I see two uses of this interface, both in combination with `Interpolatable`.
Should this just extend `Interpolatable`, or are there cases to be expected
where this marker is present but `Interpolatable` is not?
Also, have you considered adding a default method to `Interpolatable` to
indicate it supports component wise interpolation?
It looks modelled after `RandomAccess`, but the reasons for that being a marker
interface are not similar to this situation (it is a marker interface so it can
also mark the old collections, like `Vector`).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1702341296
