On Fri, 2 Aug 2024 16:19:15 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/css/StyleableLongProperty.java 
>> line 136:
>> 
>>> 134:         @Override
>>> 135:         public void onUpdate(double progress) {
>>> 136:             set(progress < 1 ? startValue + (long)((endValue - 
>>> startValue) * progress) : endValue);
>> 
>> minor: should it use (long)Math.round() ?
>
> edit: I think it should.

You're right, I've updated the implementation and added tests.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1707796319

Reply via email to