On Tue, 23 Jul 2024 05:08:31 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - review comments >> - Merge branch 'master' into 8336331.acc.attr >> - 8336331: Doc: Clarification in AccessibleAttribute, AccessibleRole > > modules/javafx.graphics/src/main/java/javafx/scene/AccessibleAttribute.java > line 694: > >> 692: /** >> 693: * Returns the text selection start offset for the node. >> 694: * Selection start corresponds to the smaller offset in the >> selection range. > > Just an observation, The selection is represented by IndexRange where we > refer the start and end as **index**. But here in this file, we refer them as > offset. Hmm, actually, `IndexRange.getStart()` L76 and `.getEnd()` L84 refer to start/end _position_. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1512#discussion_r1688210575
