On Tue, 23 Jul 2024 04:57:29 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Minor clarifications in Javadoc
>>
>> **AccessibleAttribute**:
>> - Point2D and Bound values uses screen coordinates. Example: `BOUNDS`,
>> `BOUNDS_FOR_RANGE`, `OFFSET_AT_POINT`, ...
>> - clarified the meaning of `SELECTION_END`, `SELECTION_START`
>>
>> **Accessible Role**:
>> - missing accessible action `SHOW_TEXT_RANGE`
>>
>> This will be a minor clarification, so no CSR is required.
>
> modules/javafx.graphics/src/main/java/javafx/scene/AccessibleRole.java line
> 486:
>
>> 484: * <li> {@link AccessibleAction#SET_TEXT} </li>
>> 485: * <li> {@link AccessibleAction#SET_TEXT_SELECTION} </li>
>> 486: * <li> {@link AccessibleAction#SHOW_TEXT_RANGE} </li>
>
> As per the documentation of `AccessibleAction.SHOW_TEXT_RANGE`, it used by
> both TextField and TextArea.
> Given that, we should add this action for TEXT_FILED role also.
Thanks for catching this!
Only TextArea has a meaningful implementation, all other descendants of
TextInputControl have a no-op (see `scrollCharacterToVisible()`,
TextInputControlSkin:736)
We need to remove TextField mention from `AccessibleAction.SHOW_TEXT_RANGE`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1512#discussion_r1688199178
