On Thu, 18 Jul 2024 19:00:06 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> Minor clarifications in Javadoc
>
> **AccessibleAttribute**:
> - Point2D and Bound values uses screen coordinates. Example: `BOUNDS`,
> `BOUNDS_FOR_RANGE`, `OFFSET_AT_POINT`, ...
> - clarified the meaning of `SELECTION_END`, `SELECTION_START`
>
> **Accessible Role**:
> - missing accessible action `SHOW_TEXT_RANGE`
>
> This will be a minor clarification, so no CSR is required.
Suggesting a minor addition, otherwise LGTM.
modules/javafx.graphics/src/main/java/javafx/scene/AccessibleAttribute.java
line 694:
> 692: /**
> 693: * Returns the text selection start offset for the node.
> 694: * Selection start corresponds to the smaller offset in the
> selection range.
Just an observation, The selection is represented by IndexRange where we refer
the start and end as **index**. But here in this file, we refer them as offset.
modules/javafx.graphics/src/main/java/javafx/scene/AccessibleRole.java line 486:
> 484: * <li> {@link AccessibleAction#SET_TEXT} </li>
> 485: * <li> {@link AccessibleAction#SET_TEXT_SELECTION} </li>
> 486: * <li> {@link AccessibleAction#SHOW_TEXT_RANGE} </li>
As per the documentation of `AccessibleAction.SHOW_TEXT_RANGE`, it used by both
TextField and TextArea.
Given that, we should add this action for TEXT_FILED role also.
-------------
Changes requested by arapte (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1512#pullrequestreview-2192976140
PR Review Comment: https://git.openjdk.org/jfx/pull/1512#discussion_r1687429948
PR Review Comment: https://git.openjdk.org/jfx/pull/1512#discussion_r1687423402
