On Tue, 16 Jul 2024 19:30:04 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java >> line 686: >> >>> 684: root.getChildren().addAll(a); >>> 685: >>> 686: assertDoesNotThrow(() -> stage.show()); // This should not >>> result in a StackOverflowError >> >> Since this is still a JUnit 4 test, perhaps replace this with a try/catch >> and call `Assert.fail` in the `catch` block? > > Yeah, I can change that, I was hoping this (less important) PR would probably > be integrated after #1503 Now that PR #1515 is integrated, this is fine. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1505#discussion_r1686714538
