On Tue, 16 Jul 2024 16:58:35 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix formatting and spelling
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java
> line 691:
>
>> 689: @Test
>> 690: public void shouldDetectNestedInfiniteLoop() throws IOException {
>> 691: Stylesheet stylesheet = new CssParser().parse(
>
> `CssParser.parse(String,String)` is used only in tests, why are we using it?
> Shouldn't we use `CssParser.parse(String)` instead?
>
> Also, why do we need `CssParser.parse(String,String)` in the first place?
I can change it; I just followed what was done in this file already.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1505#discussion_r1679972902
