On Tue, 16 Jul 2024 18:06:54 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java >> line 43: >> >>> 41: import static org.junit.Assert.assertFalse; >>> 42: import static org.junit.Assert.assertTrue; >>> 43: import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; >> >> We have a general "best practice" to not mix JUnit 4 and JUnit 5 calls in >> the same test class. > > how did I miss that??? Worth noting is that PR #1503 also uses JUnit 5 for its new tests, and in a non-trivial manner (not easy to replace). Maybe the best thing to do is to convert this test class to JUnit 5? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1505#discussion_r1679845670
