On Mon, 6 Nov 2023 08:31:54 GMT, vlaaad <d...@openjdk.org> wrote: >> When a function key is pressed >> [NSFunctionKeyMask](https://developer.apple.com/documentation/appkit/nsfunctionkeymask) >> is automatically included by the system. >> Hence it looks not breaking behavior with this change. >> As the warning is quite clear it looks logical to not include the modifier. >> Tested on macOS 12.6.8, warning appears without this change and disappears >> with this change. >> >> Can you please check _MenuItemTest.java_ test file and try to add a unit >> test, at least a mac specific test, which should press a Function key and >> check that modifiers in the received event contains Function modifier flag. > > @arapte anything else I could do?
@vlaaad Yes please, I think we should have a test along with this fix. A test is missing for this scenario. If a unit test is not feasible, can you please check to add a system test ? ( may be something like setting F1 as accelerator key on a MenuItem results in MenuItem's action getting fired when Function+F1 is pressed ) ------------- PR Comment: https://git.openjdk.org/jfx/pull/1252#issuecomment-1795727652
