On Fri, 14 Jul 2023 12:31:49 GMT, Karthik P K <k...@openjdk.org> wrote:
>> In `TreeTableRowSkin`, graphic was not updated along with tree item update.
>>
>> Made changes to update graphics of TreeTableView row in `updateTreeItem()`
>> method.
>>
>> Added options in monkey tester to add graphics and subnodes to
>> `TreeTableView` rows.
>
> Karthik P K has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add unit test
the test passes with the fix, fails in the master branch.
one minor suggestion, unrelated, but probably worth addressing in to this PR.
modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableRowSkinTest.java
line 407:
> 405:
> 406: @AfterEach
> 407: public void after() {
unrelated to the current PR, but could this method be more defensive, to avoid
any problems with the invocation order?
@AfterEach
public void after() {
if (stageLoader != null) {
stageLoader.dispose();
stageLoader = null;
}
}
-------------
Marked as reviewed by angorya (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1172#pullrequestreview-1530560923
PR Review Comment: https://git.openjdk.org/jfx/pull/1172#discussion_r1263894796
