On Sat, 8 Jul 2023 10:15:47 GMT, Marius Hanl <mh...@openjdk.org> wrote:
> Is it possible to write a Unit test as well? I tried to write unit test but since it should be checked if the graphic is cleared while collapsing the tree and added back while expanding, I couldn't find out a way to do this. I tried to use `VirtualFlowTestUtils.assertGraphicIsVisible()` method similar to how it is used in `TreeTableViewTest` to do the same but it did not help in this case. Please let me know if you have any suggestions. > For these kinds of changes, I think it is important to have a performance > check as well (e.g. count the number of invocations to updateItem etc). I have checked my changes using the program given in [JDK-8143266](https://bugs.openjdk.org/browse/JDK-8143266). I did not find performance degradation as a result of my changes. Do you suggest writing separate test for this? Please let me know your suggestion. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1172#issuecomment-1630750269
