On Tue, 6 Jun 2023 00:57:20 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> 
wrote:

> I changed it to use `_updateViewSize` so it's compatible with other platforms.

As it turns out, I was looking at your incremental diff and (mistakenly) 
thought that `_updateViewSize` was in the current mainline code base and that 
you had removed it, which is why I asked about it. I now see that what happened 
is that the initial version of your PR had added it, and a later version had 
reverted that addition. And your most recent version added it back in. I don't 
mind either way, so if you think it's cleaner to implement `_updateViewSize` on 
Linux (even though today it's only implemented on Windows), that's OK. If you 
want to revert this latest addition of that method, that's OK, too.

> I'm gathering some information to answer about the test changes.

Thanks.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1110#issuecomment-1578830605

Reply via email to