On Sat, 20 May 2023 16:19:19 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> 
wrote:

>> I replicated the fix on #1054 on Linux.
>> 
>> Also fixes [Monocle: Stage no longer gets focus after fix for 
>> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix MouseEventFirerTest.java

There is another failing test with this patch:


DialogRepeatedShowHideTest > dialogSizeOnReShownTest FAILED
    java.lang.AssertionError: Dialog height should remain the same 
expected:<300.0> but was:<79.0>
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:555)
        at 
test.robot.javafx.scene.dialog.DialogRepeatedShowHideTest.dialogSizeOnReShownTest(DialogRepeatedShowHideTest.java:71)


It looks like this fix has reintroduced 
[JDK-8193502](https://bugs.openjdk.org/browse/JDK-8193502) -- the test case 
attached to that bug report now fails.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1110#issuecomment-1572539075

Reply via email to