On Mon, 5 Jun 2023 22:50:00 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> I ran an automated test job using your latest patch and all of the tests now > pass. > > > Maybe it's possible to do a Java fix where the new Scene without size > > inherits the old Scene size? This way I think it possible to remove > > platform specific code such as the one I did and `_updateViewSize`. > > Hmm. That might be problematic. In any case, I don't want to go down that > route to fix this bug. > > I have two questions on the current version of the fix: > > 1. Can you explain why the two tests had to be changed? Unless the tests > in question really were buggy, and just getting luck before, the changes > suggest a change in behavior that applications might notice and be bothered > by. > > 2. Are you sure that on Linux, there are no cases where `_updateViewSize` > needs to be implemented? Did you consider just leaving it as-is or would that > have failed? I changed it to use `_updateViewSize` so it's compatible with other platforms. I'm gathering some information to answer about the test changes. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1110#issuecomment-1577740976
