On Wed, 9 Nov 2022 19:08:05 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> Marius Hanl has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8295078: Replace JUnit4 with Junit5 imports
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/AnchorPane.java 
> line 283:
> 
>> 281:         }
>> 282: 
>> 283:         return snappedLeftInset() + max + snappedRightInset();
> 
> Have you verified that `max` ends up as a snapped value in all cases? Some of 
> the values that are used in the computation of max clearly are snapped, such 
> as `computeChildPrefAreaWidth` (which is a method in the Region superclass 
> that returns a snapped result), but others might not be.

besides the anchor everything is snapped properly here already.

-------------

PR: https://git.openjdk.org/jfx/pull/910

Reply via email to