On Tue, 8 Nov 2022 18:34:09 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8295078: Replace JUnit4 with Junit5 imports > > modules/javafx.graphics/src/main/java/javafx/scene/layout/AnchorPane.java > line 364: > >> 362: } >> 363: >> 364: child.resizeRelocate(x, y, w, h); > > snapping should be done at this moment, I think, something like this: > > child.resizeRelocate( > snapPositionX(x), > snapPositionY(y), > snapSizeX(w), > snapSizeY(h)); > > and keep the original (unsnapped) code prior to this. It depends (see earlier discussion), but if we are going to snap the intermediate results, we need to be sure we are doing it consistently -- adding snapped insets to an unsnapped value is very likely the wrong thing to do. ------------- PR: https://git.openjdk.org/jfx/pull/910
