I would think against it, because - it's very inefficient to send a Skipped event for each missed task than to collect all the data and send it in one shot - it's faster to send the event from the sstate.bbclass than to return the task ids and then call again a python function to generate the sstate file names - basically replicating the sstate.bbclass code in bitbake - the queueTaskSkipped event has a different semantic than what we need here to return a whole batch of data; creating a new event type from scratch is a bit pointless since the inheritance would need to be broken - knotty can receive MetadataEvents just as well as sceneTaskSkipped event, or any variation of it
I would suggest actually just sending this event at all times, not just when toaster is enabled. Please advise, Alex On Thu, Feb 20, 2014 at 2:30 PM, Richard Purdie < richard.pur...@linuxfoundation.org> wrote: > On Mon, 2014-02-17 at 17:33 +0000, Alex DAMIAN wrote: > > From: Alexandru DAMIAN <alexandru.dam...@intel.com> > > > > Toaster needs to record the attempts to restore > > setscene tasks that don't have a sstate file. > > > > We build a list of tasks for which we can't find an > > sstate file, and if we're running under Toaster data > > collection, we send it off with a MetadataEvent. > > > > Signed-off-by: Alexandru DAMIAN <alexandru.dam...@intel.com> > > --- > > meta/classes/sstate.bbclass | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > I'm wondering if we should perhaps do this in bitbake and add a setscene > "missed" event type there based upon the return value of this function? > > Ideally I'd like to be able to report the stats in knotty too. > > Cheers, > > Richard > > -- Alex Damian Yocto Project SSG / OTC
_______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
