On Tue, Apr 9, 2013 at 12:07 PM, Richard Purdie
<richard.pur...@linuxfoundation.org> wrote:
> On Tue, 2013-04-09 at 16:44 +0200, Koen Kooi wrote:
>> Op 9 apr. 2013, om 16:41 heeft Koen Kooi <k...@dominion.thruhere.net> het
>> volgende geschreven:
>>
>> >
>> > Op 9 apr. 2013, om 16:36 heeft Otavio Salvador <ota...@ossystems.com.br>
>> > het volgende geschreven:
>> >
>> >> On Tue, Apr 9, 2013 at 9:35 AM, Richard Purdie
>> >> <richard.pur...@linuxfoundation.org> wrote:
>> >>> On Mon, 2013-04-08 at 19:29 +0300, Radu Moisan wrote:
>> >>>> Along with v182 upgrade udevd was moved to ${base_libdir}
>> >>>> making scripts like init-live.sh to fail in finding udevd
>> >>>>
>> >>>> Fixes [Yocto #4046]
>> >>>>
>> >>>> Signed-off-by: Radu Moisan <radu.moi...@intel.com>
>> >>>> ---
>> >>>> meta/recipes-core/udev/udev.inc | 3 ++-
>> >>>> meta/recipes-core/udev/udev_182.bb | 2 +-
>> >>>> 2 files changed, 3 insertions(+), 2 deletions(-)
>> >>>
>> >>> We needed a decision on this. I've rewritten the commit message and
>> >>> merged it. Most of the feedback was about the commit message, not the
>> >>> patch itself. There were also no better proposals for how we could
>> >>> actually fix the bugs we were seeing.
>> >>
>> >> If I read the thread right, it had two NACK's. So it wasn't a cosmetic
>> >> commit log issue.
>> >
>> > 4 replies to the patch:
>> >
>> > 1) me asking about the commit log
>> > 2) me NACK'ing the patch
>
> Without any constructive way of fixing the issues. As I've said,
> "fixing" the other scripts does not work. Nobody has proposed any
> reasonable realistic way of unbreaking the multilib support which worked
> prior to the udev upgrade. Nobody has actually taken the time to even
> understand what is breaking as far as I can tell.
>
>> > 3) Otavio NACK'ing the ptch
>
> Again, not constructively. People saying "no" just because they dislike
> it doesn't really work.
It wasn't the case and I even pointed out the systemd-udevd problem
which has not been fixed so it was not "no" but a justified NACK. If
our NACK'ing is ignored what is the matter of people using their time
to comment in something?
>> > 4) RP mentioning other discussions
>>
>> And by the way, does anyone actually bother testing patches to important
>> infrastructure like udev?
>>
>> [koen@rrMBP udev]$ git log --oneline -1
>> a866e1e udev: Move udevd back to /sbin
>>
>> [koen@rrMBP udev]$ git grep /lib/udev/udevd
>> udev/init:[ -x /lib/udev/udevd ] || exit 1
>> udev/init: /lib/udev/udevd -d
>> udev/udev-cache:[ -x /lib/udev/udevd ] || exit 1
>>
>> So the patch broke the sysvinit script, congratulations!
>
> Patch screw up :(. This will get fixed shortly, sorry about that.
It seems the right fix, for now, as I commented in the bug, is to use
/lib hardcoded.
--
Otavio Salvador O.S. Systems
E-mail: ota...@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
