Op 9 apr. 2013, om 16:41 heeft Koen Kooi <k...@dominion.thruhere.net> het
volgende geschreven:
>
> Op 9 apr. 2013, om 16:36 heeft Otavio Salvador <ota...@ossystems.com.br> het
> volgende geschreven:
>
>> On Tue, Apr 9, 2013 at 9:35 AM, Richard Purdie
>> <richard.pur...@linuxfoundation.org> wrote:
>>> On Mon, 2013-04-08 at 19:29 +0300, Radu Moisan wrote:
>>>> Along with v182 upgrade udevd was moved to ${base_libdir}
>>>> making scripts like init-live.sh to fail in finding udevd
>>>>
>>>> Fixes [Yocto #4046]
>>>>
>>>> Signed-off-by: Radu Moisan <radu.moi...@intel.com>
>>>> ---
>>>> meta/recipes-core/udev/udev.inc | 3 ++-
>>>> meta/recipes-core/udev/udev_182.bb | 2 +-
>>>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>>
>>> We needed a decision on this. I've rewritten the commit message and
>>> merged it. Most of the feedback was about the commit message, not the
>>> patch itself. There were also no better proposals for how we could
>>> actually fix the bugs we were seeing.
>>
>> If I read the thread right, it had two NACK's. So it wasn't a cosmetic
>> commit log issue.
>
> 4 replies to the patch:
>
> 1) me asking about the commit log
> 2) me NACK'ing the patch
> 3) Otavio NACK'ing the ptch
> 4) RP mentioning other discussions
>
> So 25% of the replies are about cosmetics, how is that "most of the replies"?
And by the way, does anyone actually bother testing patches to important
infrastructure like udev?
[koen@rrMBP udev]$ git log --oneline -1
a866e1e udev: Move udevd back to /sbin
[koen@rrMBP udev]$ git grep /lib/udev/udevd
udev/init:[ -x /lib/udev/udevd ] || exit 1
udev/init: /lib/udev/udevd -d
udev/udev-cache:[ -x /lib/udev/udevd ] || exit 1
So the patch broke the sysvinit script, congratulations!
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
