sander added a comment.
Sorry for being a pain, but your patch contains lots of whitespace changes again (in conf/dlgaccessibilitybase.ui). I agree that you probably do want them changed, but please do so in a separate patch. Besides, can you please post your patch as a merge request on https://invent.kde.org/kde/okular/ ? That is not purely cosmetic -- invent.kde.org has a CI system. Besides that: I like the patch! INLINE COMMENTS > dlgaccessibility.cpp:43 > + } > + m_dlg->kcfg_ttsEngine->setProperty("kcfg_property", > QByteArray("currentText")); > +#else This doesn't follow the coding style in the rest of the file: There should be a whitespace right after '(' and before ')'. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D24102 To: whiting, aacid Cc: sander, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid
