aacid added a comment.

  Sounds sensible, what about the TODO you have on the top?

INLINE COMMENTS

> dlgaccessibility.cpp:36
> +    // Populate tts engines
> +    QStringList engines = QTextToSpeech::availableEngines();
> +    foreach (const QString &engine, engines) {

const

> dlgaccessibility.cpp:37
> +    QStringList engines = QTextToSpeech::availableEngines();
> +    foreach (const QString &engine, engines) {
> +        m_dlg->kcfg_ttsEngine->addItem (engine);

use for (  :  )

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D24102

To: whiting, aacid
Cc: sander, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, ngraham, darcyshen, aacid

Reply via email to