sander added a comment.

  How did you determine the value of the `damping` variable?  You write
  
    With this patch this automatic scrolling goes at 60 fps instead of 10, I 
made it so that the speed of the scroll is the same.
  
  If somebody in the future changes the scroll speed, will you have to update 
your patch?  Wouldn't it be better to have only one constant that determines 
the speed of both regular scrolling and automatic scrolling?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D20437

To: kezik, #okular, aacid
Cc: sander, ngraham, aacid, ahmedbilal, okular-devel, kezik, joaonetto, tfella, 
darcyshen

Reply via email to