> On Nov. 17, 2016, 10:29 p.m., Albert Astals Cid wrote: > > adding default: is not a good idea, it will silence warnings in teh future > > when new enums are added. > > > > You don't want to silence the warnings, you want to fix them.
Your concern is valid in general, but in this case I would be very surprised if RenditionAction gained a new operation. Anyway, in the meantime the last two hunks have been taken care of by Martin T. H. Sandsmark. The first hunk (the dvi generator) is still a useful fix for a maybe-uninitialized warning. - Miklós ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129286/#review100919 ----------------------------------------------------------- On Oct. 30, 2016, 3:29 p.m., Miklós Máté wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129286/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2016, 3:29 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > The one in the DVI generator is a maybe-unused warning, but it's a false > positive, because there were no unhandled enum values. > > > Diffs > ----- > > generators/dvi/generator_dvi.cpp d1536cc > ui/pageview.cpp bb540cb > ui/presentationwidget.cpp e6ecdc5 > > Diff: https://git.reviewboard.kde.org/r/129286/diff/ > > > Testing > ------- > > > Thanks, > > Miklós Máté > >
