----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129286/#review100919 -----------------------------------------------------------
adding default: is not a good idea, it will silence warnings in teh future when new enums are added. You don't want to silence the warnings, you want to fix them. - Albert Astals Cid On Oct. 30, 2016, 2:29 p.m., Miklós Máté wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129286/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2016, 2:29 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > The one in the DVI generator is a maybe-unused warning, but it's a false > positive, because there were no unhandled enum values. > > > Diffs > ----- > > generators/dvi/generator_dvi.cpp d1536cc > ui/pageview.cpp bb540cb > ui/presentationwidget.cpp e6ecdc5 > > Diff: https://git.reviewboard.kde.org/r/129286/diff/ > > > Testing > ------- > > > Thanks, > > Miklós Máté > >
