> On Feb. 28, 2016, 11:17 a.m., Albert Astals Cid wrote: > > Can you please put the diffs in review board and not as attached files? > > Albert Astals Cid wrote: > Or you did that in addition to attaching the files? I'm not sure what i > have to review now. Can you confirm > https://git.reviewboard.kde.org/r/127013/diff/raw/ has the patch you want > reviewed?
I used "Update diff", I don't know why it created those attachments. Oh, wait, I know. First I tried to drag&drop twice, but nothing happened, then I used the file select dialog, which seemed to work. When confirming the change it didn't show that it would also create those attachments. I confirm that the diff view and "download diff" present the new version. I can delete the attachments if they are confusing. - Miklós ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127013/#review92846 ----------------------------------------------------------- On Feb. 27, 2016, 10:30 a.m., Miklós Máté wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127013/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2016, 10:30 a.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > fixes bug #342076 > > > Diffs > ----- > > ui/tocmodel.cpp ce93366 > > Diff: https://git.reviewboard.kde.org/r/127013/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > okular_marker_v2.diff > > https://git.reviewboard.kde.org/media/uploaded/files/2016/02/27/78357c93-a723-4e1b-8a8d-638d49ed334e__okular_marker_v2.diff > okular_marker_v2.diff > > https://git.reviewboard.kde.org/media/uploaded/files/2016/02/27/c4395f9d-2991-4f6c-bf36-d973dbcb5b64__okular_marker_v2.diff > > > Thanks, > > Miklós Máté > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
