> On Feb. 18, 2016, 12:16 a.m., Miklós Máté wrote: > > ui/tocmodel.cpp, line 152 > > <https://git.reviewboard.kde.org/r/127013/diff/1/?file=443812#file443812line152> > > > > No. This function marks all the TOC items that contain the current > > page, but later in the data() method they are filtered, and in the end only > > one triangle marker will be shown (depending on how the tree is expanded in > > the view). If there are multiple TOC items on the same level that point to > > the same page, this algorithm only marks the last one. > > Albert Astals Cid wrote: > I'm not convinced marking the last one is the best, could we mark "the > correct" one? After all we know the viewports for the two items so we know > what's more correct than the other, no? If you need such a document i can > send it to you. > > Miklós Máté wrote: > TOCModel::setCurrentViewport() is only called when the page number > changes. What do you mean "the correct one"?
Sure but there's notifyViewportChanged too so maybe we can make it listen to that and thus point to the one that of the N TOC items pointing to that page that has a closer viewport, or "closer and after", no? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127013/#review92516 ----------------------------------------------------------- On Feb. 8, 2016, 5:49 p.m., Miklós Máté wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127013/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2016, 5:49 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > fixes bug #342076 > > > Diffs > ----- > > ui/toc.cpp 09625af > ui/tocmodel.cpp ce93366 > > Diff: https://git.reviewboard.kde.org/r/127013/diff/ > > > Testing > ------- > > > Thanks, > > Miklós Máté > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
