-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125801/
-----------------------------------------------------------

(Updated Nov. 5, 2015, 7:35 p.m.)


Review request for Okular and Albert Astals Cid.


Changes
-------

aacid: This leads to similar behavior across both PDFs and non-PDF documents. 
Although the word wrapping isn't working on non-PDF documents. Thus, it also 
fixes the issue with overlapping borders.


Bugs: 332887
    http://bugs.kde.org/show_bug.cgi?id=332887


Repository: okular


Description
-------

Make inline annotation border width customizable, using a spin widget to accept 
input


Diffs (updated)
-----

  conf/widgetannottools.cpp 6d05eed 
  ui/annotationwidgets.h 6e7a218 
  ui/annotationwidgets.cpp 450e50b 
  ui/pagepainter.cpp 6eed5b6 

Diff: https://git.reviewboard.kde.org/r/125801/diff/


Testing
-------

Saved a document with various widths for border from 0 to more.

Opened it in okular itself, and it worked.
The unpatched version of okular also works fine, and uses the same width as set 
using the patched version.

Other pdf readers on linux (`evince`, `zathura`, `acroread-9.5.5`), do not 
display any annotations. No matter which okular (patched or unpatched) is used 
to create them.


Thanks,

Sumit Sahrawat

_______________________________________________
Okular-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/okular-devel

Reply via email to