----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125801/#review87628 -----------------------------------------------------------
Thanks for the patch, looking good :) Some bits that need fixing: * This property is not saved if you modify the default annotation tool (in Configure Okular... -> Annotations) * ui/pagepainter.cpp needs to be patched too, to make this property work on non-PDF documents too. This is probably just a matter of setting the pen width around line 709. - Albert Astals Cid On oct. 26, 2015, 6:14 a.m., Sumit Sahrawat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125801/ > ----------------------------------------------------------- > > (Updated oct. 26, 2015, 6:14 a.m.) > > > Review request for Okular and Albert Astals Cid. > > > Bugs: 332887 > http://bugs.kde.org/show_bug.cgi?id=332887 > > > Repository: okular > > > Description > ------- > > Make inline annotation border width customizable, using a spin widget to > accept input > > > Diffs > ----- > > ui/annotationwidgets.h 6e7a218 > ui/annotationwidgets.cpp 450e50b > > Diff: https://git.reviewboard.kde.org/r/125801/diff/ > > > Testing > ------- > > Saved a document with various widths for border from 0 to more. > > Opened it in okular itself, and it worked. > The unpatched version of okular also works fine, and uses the same width as > set using the patched version. > > Other pdf readers on linux (`evince`, `zathura`, `acroread-9.5.5`), do not > display any annotations. No matter which okular (patched or unpatched) is > used to create them. > > > Thanks, > > Sumit Sahrawat > >
_______________________________________________ Okular-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/okular-devel
