> On April 9, 2015, 1:58 a.m., Jan Kundrát wrote: > > -1 from me. The unconditional dep got introduced in > > 93918b1ec8f585dd135db1449e1b22b878f82fbc, which looks like a mistake to me. > > Why not: > > - > > - find_package(KF5 CONFIG COMPONENTS Activities)
While I don't mind making it again an optional dep, I want to mention that the Gwenview, Kate and KWrite made it a hard requirement. Is there a reason why Okular needs it to be optional? - Ivan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123249/#review78690 ----------------------------------------------------------- On April 3, 2015, 8:39 p.m., Ivan Čukić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123249/ > ----------------------------------------------------------- > > (Updated April 3, 2015, 8:39 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > ------- > > Since the a3fb02b881d commit, the KF5::Activities are a required dependency > (CMakeLists.txt:31). > > Still, the actual code uses ifdefs for KActivities_FOUND macro which no > longer exists. This patch removes the macros and restores the feature. > > > Diffs > ----- > > autotests/CMakeLists.txt 0a0f546 > shell/CMakeLists.txt ec36582 > shell/shell.h f345cf3 > shell/shell.cpp 6bb89c5 > > Diff: https://git.reviewboard.kde.org/r/123249/diff/ > > > Testing > ------- > > > Thanks, > > Ivan Čukić > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
