----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106685/#review19860 -----------------------------------------------------------
CMakeLists.txt <http://git.reviewboard.kde.org/r/106685/#comment15771> I'd prefer if you movedthis to the shell CMakeLists.txt so it's more compact shell/shell.cpp <http://git.reviewboard.kde.org/r/106685/#comment15770> This doesn't seem to compile against the KActivities of KDE 4.9.x can you please refine the Kactivities cmake check so it properly detects the activities library version it really needs? - Albert Astals Cid On Oct. 3, 2012, 9:29 p.m., Ivan Čukić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106685/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2012, 9:29 p.m.) > > > Review request for Okular, Plasma and Albert Astals Cid. > > > Description > ------- > > Okular reports the open/close document events to activity manager daemon. > Side-effect - support for Share-Like-Connect applet. > > (and some trailing spaces auto-removal) > > > Diffs > ----- > > CMakeLists.txt a057e82 > shell/CMakeLists.txt 1bf0b4f > shell/shell.h 393d6c6 > shell/shell.cpp 70e2e99 > > Diff: http://git.reviewboard.kde.org/r/106685/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Ivan Čukić > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
