> On Oct. 2, 2012, 6:13 p.m., Albert Astals Cid wrote: > > Any reason this is at the Document level and not at the Part level? Feels > > to me it belongs more into the part than the document. > > Ivan Čukić wrote: > This is really meant to be a document-link (Resource == Document most of > the time -> thus ResourceInstance is kinda DocumentInstance) with one small > peculiarity - the need for the window id because of share-like-connect. > > The second thing is that, for the directory listing, we might need some > special handling* so I didn't want to make it work by reporting the location > just yet. > > * for example, it could report the path the user is browsing, but to > report the selected files on request (for share-like-connect)
Forget the last two paragraphs, meant this is the Gwenview patch review. - Ivan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106685/#review19772 ----------------------------------------------------------- On Oct. 2, 2012, 4:15 p.m., Ivan Čukić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106685/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2012, 4:15 p.m.) > > > Review request for Okular, Plasma and Albert Astals Cid. > > > Description > ------- > > Okular reports the open/close document events to activity manager daemon. > Side-effect - support for Share-Like-Connect applet. > > (and some trailing spaces auto-removal) > > > Diffs > ----- > > CMakeLists.txt a057e82 > core/document.cpp 143d598 > core/document_p.h 91a5577 > > Diff: http://git.reviewboard.kde.org/r/106685/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Ivan Čukić > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
