----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105890/#review17670 -----------------------------------------------------------
Ship it! Still can't get it to work (getting phonon configured is not as easy as i'd like) but since i guess it's working for Olivier (otehrwise how did he do the suggestions) and for you too, that makes it more than 1 and the code is not ultra-ugly so feel free to commit (master only please) - Albert Astals Cid On Aug. 15, 2012, 10:19 a.m., Tobias Koenig wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105890/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2012, 10:19 a.m.) > > > Review request for Okular and Albert Astals Cid. > > > Description > ------- > > The patch extends the VideoWidget to either show the actual video player and > keep it hidden while not playing (in non-poster mode) or show an image of the > first frame all the time and overlay it with the video player (in poster > mode). > > > Diffs > ----- > > CMakeLists.txt e4cb88f > cmake/modules/FindPoppler.cmake ffa6950 > core/movie.h cbe382e > core/movie.cpp 94e71a9 > generators/poppler/config-okular-poppler.h.cmake df89d68 > generators/poppler/generator_pdf.cpp 71c962c > ui/pageview.cpp bcb4795 > ui/presentationwidget.cpp f4da539 > ui/snapshottaker.h PRE-CREATION > ui/snapshottaker.cpp PRE-CREATION > ui/videowidget.h e82753c > ui/videowidget.cpp 7d80b43 > > Diff: http://git.reviewboard.kde.org/r/105890/diff/ > > > Testing > ------- > > Using the files provided as attachment in > https://bugs.kde.org/show_bug.cgi?id=301603 > > > Thanks, > > Tobias Koenig > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
