----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105890/ -----------------------------------------------------------
(Updated Aug. 8, 2012, 9:23 a.m.) Review request for Okular and Albert Astals Cid. Changes ------- Add new version of the patch that includes the missing @since tags and removes the unneeded seek() call. Description ------- The patch extends the VideoWidget to either show the actual video player and keep it hidden while not playing (in non-poster mode) or show an image of the first frame all the time and overlay it with the video player (in poster mode). Diffs (updated) ----- CMakeLists.txt e4cb88f cmake/modules/FindPoppler.cmake ffa6950 core/movie.h cbe382e core/movie.cpp 94e71a9 generators/poppler/config-okular-poppler.h.cmake df89d68 generators/poppler/generator_pdf.cpp 71c962c ui/pageview.cpp b74941d ui/presentationwidget.cpp f4da539 ui/snapshottaker.h PRE-CREATION ui/snapshottaker.cpp PRE-CREATION ui/videowidget.h e82753c ui/videowidget.cpp 7d80b43 Diff: http://git.reviewboard.kde.org/r/105890/diff/ Testing ------- Using the files provided as attachment in https://bugs.kde.org/show_bug.cgi?id=301603 Thanks, Tobias Koenig
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
