> On May 22, 2012, 10:48 p.m., Albert Astals Cid wrote: > > Hmmm, having a bad feeling about this, have you actually checked that > > changing the memory usage level from the config dialog still works?
You were correct, Settings class needs to be derived from SettingsCore in order to have all settings options available for KConfigManager. I have tested with these changes and I am able to modify the memory usage level, but still unsure if this is working as expected (the option appears in the configuration file). Note that currently in part.cpp both classes (Settings and SettingsCore) need to be initialized even if Settings is derived from SettingsCore. Since both classes use the same configuration file, I am not sure if there could be an interference between the two, or different files should be used. Anyway, more testing needs to be done. - Bogdan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review14067 ----------------------------------------------------------- On June 3, 2012, 8:30 p.m., Bogdan Cristea wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104947/ > ----------------------------------------------------------- > > (Updated June 3, 2012, 8:30 p.m.) > > > Review request for Okular. > > > Description > ------- > > Default settings file should be separated in two different files in order to > have a better separation between okular core library (back end) and the front > end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request > includes only the separation of okular.kcfg in two files: > -okular.kcfg (front end) > -okular_core.kcfg (back end) > > > Diffs > ----- > > CMakeLists.txt 0034cf3 > conf/okular.kcfg 6ad0e19 > conf/okular_core.kcfg PRE-CREATION > conf/settings.kcfgc 0b70390 > conf/settings_core.kcfgc PRE-CREATION > core/document.cpp 0ebc34e > core/script/kjs_fullscreen.cpp c07ac4e > core/texteditors_p.h 171dc69 > okular.spec PRE-CREATION > part.cpp 4c6aac8 > ui/pagepainter.cpp ca55e81 > ui/pageview.cpp 4be5e6b > ui/presentationwidget.cpp a3b8be4 > > Diff: http://git.reviewboard.kde.org/r/104947/diff/ > > > Testing > ------- > > No > > > Thanks, > > Bogdan Cristea > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
